Repository navigation
chore: upgrade dependencies and fix compatibility - #58
Conversation
Update npm packages and lockfile, align Node and supported lint/toolchain versions, and fix UI/prerender compatibility after upgrades. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the completion-route hydration issue and update CI to validate Node.js 22+.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Upgrades dependencies and Node.js requirements while fixing icon compatibility, hydration safety, and Jest configuration.
Changes:
- Refreshes dependencies and raises the runtime requirement to Node.js 22+.
- Uses Node.js 24 in Docker and updates Jest exclusions.
- Replaces removed Lucide icons and defers browser-only voting-history access.
| File | Summary |
|---|---|
README.md |
Documents the Node.js 22+ requirement. |
package.json |
Updates dependencies and runtime constraints. |
jest.config.js |
Excludes build output and dependencies. |
Dockerfile |
Uses Node.js 24 Alpine. |
components/Footer.tsx |
Replaces removed Lucide brand icons. |
app/vote/certificate/page.tsx |
Defers voting-history loading until hydration. |
Two moderate issues remain: the completion route may still have a hydration mismatch, and CI continues to run on unsupported Node.js 20.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67c997bed4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "engines": { | ||
| "node": ">=18.18.0", | ||
| "node": ">=22.0.0", |
There was a problem hiding this comment.
The test job in .github/workflows/ci.yml still configures node-version: '20', so it runs the upgraded project outside the minimum runtime declared here. In particular, the newly selected @testing-library/jest-dom@7.0.1 also declares Node.js 22 as its minimum, yet jest.setup.js imports it for every test; therefore the lint/type-check/test job installs and executes an unsupported toolchain and may fail or provide misleading validation. Update the workflow's Node version along with this engine bump.
Useful? React with 👍 / 👎.
The npm dependency set was behind current releases, and upgrading exposed UI and server-rendering compatibility issues. This updates the application and development toolchain while keeping clean installs and production builds working.
@types/bcryptjsand@types/uuidstubs.@types/nodeon 24 to match the container.TypeScript remains on the latest compatible 6.x because
@typescript-eslintdoes not yet support 7.x; ESLint remains on 9.x because plugins supplied byeslint-config-nextdo not yet accept 10.x.Verified with
npm ci, the production build, lint, all 64 tests, andnpm audit(zero reported vulnerabilities).